feat(ui5-time-picker): display-value and value-format properties are introduced#13071
Merged
feat(ui5-time-picker): display-value and value-format properties are introduced#13071
Conversation
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-13071--ui5-webcomponents.netlify.app |
hinzzx
requested changes
Feb 17, 2026
packages/website/docs/_samples/main/TimePicker/CustomFormatting/sample.html
Outdated
Show resolved
Hide resolved
hinzzx
approved these changes
Feb 19, 2026
tsanislavgatev
requested changes
Feb 25, 2026
packages/main/src/TimePicker.ts
Outdated
Contributor
There was a problem hiding this comment.
Fix documentation here as well, I did it in ui5-date-picker
packages/main/src/TimePicker.ts
Outdated
| _isoFormatInstance?: DateFormat; | ||
| _displayFormatInstance?: DateFormat; | ||
| _valueFormatInstance?: DateFormat; | ||
| _lastDisplayFormatPattern?: string; |
Contributor
There was a problem hiding this comment.
why do we need this?
tsanislavgatev
requested changes
Mar 4, 2026
tsanislavgatev
approved these changes
Mar 6, 2026
Sample sync reminderReact sample changed but HTML sample (
Please keep both samples in sync, or ignore if the change does not apply to both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces display-value and value-format properties to the ui5-time-picker component
Changes: